Detach ingester series from gRPC buffers to reduce heap#7670
Draft
justinjung04 wants to merge 3 commits into
Draft
Detach ingester series from gRPC buffers to reduce heap#7670justinjung04 wants to merge 3 commits into
justinjung04 wants to merge 3 commits into
Conversation
Signed-off-by: Justin Jung <jungjust@amazon.com>
998479c to
f04cbc8
Compare
Signed-off-by: Justin Jung <jungjust@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Detach series label and chunk data from gRPC unmarshal buffers in the ingester streaming path (distributor_queryable.go), allowing the Go GC to reclaim receive buffers to reduce heap usage. This is the ingester-side counterpart to #7519, which applied the same fix for the store-gateway streaming path.
Specifically:
Without this change, long-running queries hold references into gRPC receive buffers through label strings and chunk data, preventing GC from reclaiming them and causing heap to grow under heavy ingester query load.
Benchmark (100 series, 1KB chunks each):
The per-call cost of copying is ~137KB additional short-lived allocations per 100 series. The tradeoff is that gRPC receive buffers (~32KB+ each) are freed immediately after processing instead of being pinned for the entire query lifetime. Under concurrent query load, this prevents heap accumulation from unreclaimable buffers.
Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]docs/configuration/v1-guarantees.mdupdated if this PR introduces experimental flags