security: limit decompressed gzip output to prevent DoS via decompression bomb#7515
Merged
friedrichg merged 1 commit intoMay 13, 2026
Merged
Conversation
danielblando
force-pushed
the
fix/gzip-decompression-bomb
branch
4 times, most recently
from
9522e37 to
f75e698
Compare
… ingestion path Wrap gzip.Reader with io.LimitReader(maxSize+1) before reading decompressed bytes in both pkg/util/http.go and pkg/util/push/otlp.go. Signed-off-by: Daniel Blando <ddeluigg@amazon.com>
danielblando
force-pushed
the
fix/gzip-decompression-bomb
branch
from
f75e698 to
74bd5fb
Compare
friedrichg
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix unbounded gzip decompression that allows a denial-of-service attack via decompression bombs.
Using the same limit as we apply to snappy compression
Fix
Wrap
gzip.Readerwith a secondio.LimitReader(gzReader, maxSize+1)beforebuf.ReadFromin both locations:pkg/util/http.go—decompressFromReader()Gzip casepkg/util/push/otlp.go— OTLP JSON decompression pathTesting
Added
TestParseProtoReader_GzipDecompressionBombwhich creates a 1 MB payload compressed to under 4 KB and verifies that decompression is bounded (returns an error instead of allocating 1 MB).