Skip to content

Fix watchOS CI compile for proactive notification type#26

Merged
cortexark merged 1 commit into
mainfrom
fix/ci-watch-proactive-type
Apr 8, 2026
Merged

Fix watchOS CI compile for proactive notification type#26
cortexark merged 1 commit into
mainfrom
fix/ci-watch-proactive-type

Conversation

@cortexark
Copy link
Copy Markdown
Owner

Summary

  • move ProactiveNotificationType into Shared so both iOS and watchOS targets can compile it
  • remove duplicate iOS-only enum declaration from ProactiveNotificationService

Why

CI run 24158584293 failed at Build watchOS because Shared/Services/ProactiveNotificationStore referenced ProactiveNotificationType that only existed in an iOS-only file.

Validation

  • xcodebuild build -project Thump.xcodeproj -scheme ThumpWatch -destination "generic/platform=watchOS Simulator" -configuration Debug CODE_SIGN_IDENTITY="" CODE_SIGNING_REQUIRED=NO
  • xcodebuild build -project Thump.xcodeproj -scheme Thump -destination "generic/platform=iOS Simulator" -configuration Debug CODE_SIGN_IDENTITY="" CODE_SIGNING_REQUIRED=NO

@cortexark cortexark merged commit 7c2a9d3 into main Apr 8, 2026
1 check failed
@cortexark cortexark deleted the fix/ci-watch-proactive-type branch April 8, 2026 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant