Snow incidents plugin #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Also added logic to let user if no service match, and if a match but no tickets
martindstone
requested review from
cristinabuenahora and
jreock
as code owners
jreock
reviewed
Nov 21, 2024
jreock
reviewed
Nov 22, 2024
| "@octokit/auth-oauth-user" "^4.0.0" | ||
| "@octokit/request" "^8.0.2" | ||
| "@octokit/types" "^11.0.0" | ||
| "@octokit/types" "^12.0.0" |
Contributor
There was a problem hiding this comment.
Potentially breaking change, major version upgrade
jreock
reviewed
Nov 22, 2024
Contributor
There was a problem hiding this comment.
Were these library updates to yarn.lock intentional? I only noticed one potentially breaking change (octokit/types) which I commented on below, but there are a significant number of minor version changes.
jreock
reviewed
Nov 26, 2024
Contributor
jreock
left a comment
jreock
left a comment
There was a problem hiding this comment.
Just need to address yarn.lock changes, I can merge in the conflicts I just want to make sure the changes were intentional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Finishing the ServiceNow plugin that was started a while ago
This PR
Checklists
Security