Skip to content

Fix #172: Only retry on 429 rate limit errors, not 5xx server errors #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeff-schnitter merged 1 commit into from
Nov 19, 2025
Merged

Fix #172: Only retry on 429 rate limit errors, not 5xx server errors #179

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cortexapps_cli/cortex_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ def __init__(self, api_key, tenant, numeric_level, base_url='https://api.getcort
max_retries=Retry(
total=3,
backoff_factor=0.3,
status_forcelist=[500, 502, 503, 504], # Removed 429 - we avoid it with rate limiting
status_forcelist=[429], # Only retry on rate limit errors
allowed_methods=["GET", "POST", "PUT", "PATCH", "DELETE", "HEAD", "OPTIONS"],
respect_retry_after_header=True
)
Expand Down