Skip to content

Fix #171: Initialize results/failed_count before directory check in import functions #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeff-schnitter merged 1 commit into from
Nov 19, 2025
Merged

Fix #171: Initialize results/failed_count before directory check in import functions #178

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions cortexapps_cli/commands/backup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,6 +472,8 @@ def import_relationships_file(file_info):
return ("entity-relationships", len(results) - failed_count, [(fp, et, em) for rt, fp, et, em in results if et])

def _import_catalog(ctx, directory):
results = []
failed_count = 0
if os.path.isdir(directory):
print("Processing: " + directory)
files = [(filename, os.path.join(directory, filename))
Expand Down Expand Up @@ -507,6 +509,8 @@ def import_catalog_file(file_info):
return ("catalog", len(results) - failed_count, [(fp, et, em) for fn, fp, et, em in results if et])

def _import_plugins(ctx, directory):
results = []
failed_count = 0
if os.path.isdir(directory):
print("Processing: " + directory)
files = [(filename, os.path.join(directory, filename))
Expand Down Expand Up @@ -543,6 +547,8 @@ def import_plugin_file(file_info):
return ("plugins", len(results) - failed_count, [(fp, et, em) for fn, fp, et, em in results if et])

def _import_scorecards(ctx, directory):
results = []
failed_count = 0
if os.path.isdir(directory):
print("Processing: " + directory)
files = [(filename, os.path.join(directory, filename))
Expand Down Expand Up @@ -579,6 +585,8 @@ def import_scorecard_file(file_info):
return ("scorecards", len(results) - failed_count, [(fp, et, em) for fn, fp, et, em in results if et])

def _import_workflows(ctx, directory):
results = []
failed_count = 0
if os.path.isdir(directory):
print("Processing: " + directory)
files = [(filename, os.path.join(directory, filename))
Expand Down