Restore per-cluster view spike budgets#1399
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
A shared total budget makes per-cluster sampling accuracy decrease as more clusters are selected. Both policies are useful, so the per-cluster ceilings remain primary and an integer
*_totalvalue opts into a shared cap. Separately, a stale globally persisted Firing Ratex_maxcould clip spikes in fresh datasets.Validation
make lintmake format-checkmake doc-checkmake test-full: 363 passed, 1 skippeddb10401589b47fd8d56f7c66531b0c22fc7f9e91: 133 passedThe locked PyPI phylib 2.7.0 predates the existing
spikes_are_disjointselector argument already used onmaster; current phylib source is required for the application suite.