Skip to content

fix(Dropdown): keep the menu shown when visible flips back before the effect runs - #351

Merged
xidedix merged 1 commit into
v5.7from
fix/dropdown-reopen-in-one-pass
Nov 17, 2026
Merged

xidedix merged 1 commit into
v5.7from
fix/dropdown-reopen-in-one-pass

Conversation

@xidedix

@xidedix xidedix commented Nov 17, 2026 •

Copy link
Copy Markdown
Member
  • the visible effect applies only a changed state: a close and reopen (or an open and close) before it runs keeps the Popper instance, the listeners and the menu, without visibleChange
  • before: a second Popper instance and listener set, and the menu kept the inline visibility: hidden set for positioning
  • the menu still follows the current state, since Escape, click outside and Tab close it through the service before the effect runs
  • activeTrap becomes a read-only getter over the applied state; it was a writable public field, written only by the component and not in the docs

… effect runs

- the visible effect applies only a changed state: a close and reopen (or an open and close) before it runs keeps the Popper instance, the listeners and the menu, without visibleChange
- before: a second Popper instance and listener set, and the menu kept the inline visibility: hidden set for positioning
- the menu still follows the current state, since Escape, click outside and Tab close it through the service before the effect runs
- activeTrap becomes a read-only getter over the applied state; it was a writable public field, written only by the component and not in the docs
@xidedix
xidedix merged commit 4ed6679 into v5.7 Nov 17, 2026
9 checks passed
@xidedix
xidedix deleted the fix/dropdown-reopen-in-one-pass branch November 17, 2026 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant