Repository navigation
fix(integration): drop the removed Conductor integration from connect - #143
Open
polylane[bot] wants to merge 1 commit into
Open
polylane[bot] wants to merge 1 commit into
polylane[bot] wants to merge 1 commit into
Conversation
Co-authored-by: polylane[bot] <277585245+polylane[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CI typecheck on main failed because the CLI still offered the Conductor integration, which the API removed on 2026-11-05. The build regenerates the client type from the live spec, so the compiler rejected the CLI source that named Conductor. After this change the CLI no longer offers Conductor and the build compiles again. The API removed Conductor (nominal#6150, "the Conductor service is shutting down"), so the generated
IntegrationTypelostconductor.src/commands/integration/connect.tsstill declared it, andtscfailed. Removing it makesnpm run typecheckpass and no longer offers an integration the API rejects.Fix walkthrough
Watch the fix explained (1:14). Recorded for commit
67bf5581d3a6d3de92cb4ed9b048e178a8da7fbf.Production impact
CLI source-only removal; no deployed resource behavior changes
I changed only
src/commands/integration/connect.tsand its test in coreplanelabs/cli. That repository has no deploy edges in the infrastructure graph (getNodeEdgesreturned 0), so the change reaches no deployed resource; the CLI is a published package, not a running service. The edit removes a reference to an integration the API already removed, so it cannot degrade production.Observability
checksjob runsnpm run codegenthennpm run typecheckon every push; the typecheck step is the signal that this change fixes.npm testcovers the connect type-options surface (test/integration-connect-category.test.ts).Polylane assessed this pull request at
67bf558.Causal chain
2 files changed (+5/-15)
src/commands/integration/connect.ts: modified, +1/-11test/integration-connect-category.test.ts: modified, +4/-4Generated by Polylane. You can ask follow-ups by mentioning @polylane in a comment. If you close this pull request without merging, add a comment that says why. Polylane reads it to make its next fixes better.