fix: handle non-file URI schemes in runTerminalCommand for WSL2 #9325

shanevcantwell · 2025-12-26T12:06:56Z

Problem

When running run_terminal_command in WSL2, it crashes with:

run_terminal_command failed with the message: The URL must be of scheme file

Root Cause

The resolveWorkingDirectory function in runTerminalCommand.ts calls fileURLToPath() on workspace URIs. In WSL2/remote environments, getWorkspaceDirs() can return URIs like vscode-remote://wsl+Ubuntu/path instead of file:///path. The fileURLToPath function throws when the scheme isn't file://.

Fix

Wrap the fileURLToPath call in a try-catch so it falls through to the existing HOME directory fallback instead of crashing. This is a minimal, defensive change - 5 lines added.

Fixes #8091

Test plan

Tested locally in WSL2 environment where this was previously failing
Verified terminal commands execute successfully after fix

🤖 Generated with Claude Code

Summary by cubic

Fixes a crash in runTerminalCommand on WSL2 and other remote environments by resolving vscode-remote URIs to working paths and safely handling non-file workspace URIs. Falls back to HOME when resolution fails.

Bug Fixes
- Generalize remote URI support: parse vscode-remote schemes (WSL, SSH, dev-container) and decode the pathname.
- Prefer file:// workspaces and wrap fileURLToPath in try/catch; fall back to HOME when URI parsing fails.

^{Written for commit 8e5a7c2. Summary will update on new commits.}

The fileURLToPath function can throw "The URL must be of scheme file" in some WSL2/remote environments with malformed URIs. Wrap in try-catch to fall through to HOME directory fallback. Fixes continuedev#8091 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

continue · 2025-12-26T12:06:59Z

Learn more

All Green is an AI agent that automatically:

✅ Addresses code review comments

✅ Fixes failing CI checks

✅ Resolves merge conflicts

Unsubscribe from All Green comments

cubic-dev-ai

No issues found across 1 file

Parse vscode-remote://wsl+distro/path URIs to extract the actual workspace path instead of falling back to Windows HOME directory. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

cubic-dev-ai

1 issue found across 1 file (changes from recent commits).

Prompt for AI agents (all issues)


Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="core/tools/implementations/runTerminalCommand.ts">

<violation number="1" location="core/tools/implementations/runTerminalCommand.ts:58">
P2: The `url.pathname` returns URL-encoded strings (e.g., `/home/user/my%20project` instead of `/home/user/my project`). Workspace paths containing spaces or special characters will fail because the encoded path doesn&#39;t exist on the filesystem. Use `decodeURIComponent(url.pathname)` to match the decoding behavior of `fileURLToPath()` used for file:// URIs.</violation>
</file>

_{Reply to cubic to teach it or ask questions. Tag @cubic-dev-ai to re-run a review.}

core/tools/implementations/runTerminalCommand.ts

Paths with spaces or special characters (e.g., /home/user/my%20project) need decodeURIComponent() to match actual filesystem paths. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Tests cover: - Basic WSL URI parsing - URL-encoded spaces and special characters - Unicode path handling - Different WSL distro names - Priority of WSL URIs over file:// URIs - Fallback behavior - Edge cases (plus signs, percent signs, mixed encoding) - Comparison with fileURLToPath behavior 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

cubic-dev-ai

1 issue found across 1 file (changes from recent commits).

Prompt for AI agents (all issues)


Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="core/tools/implementations/resolveWorkingDirectory.vitest.ts">

<violation number="1" location="core/tools/implementations/resolveWorkingDirectory.vitest.ts:133">
P2: Environment variable modification should use `afterEach` or `try/finally` to ensure cleanup runs even if assertions fail. If this test fails, `process.env.HOME` remains set to `/test/home`, potentially causing flaky behavior in subsequent tests.</violation>
</file>

_{Reply to cubic to teach it or ask questions. Tag @cubic-dev-ai to re-run a review.}

core/tools/implementations/resolveWorkingDirectory.vitest.ts

Ensures process.env.HOME is restored even if assertions fail, preventing flaky behavior in subsequent tests. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Documents workarounds for: - Building VSIX from WSL2 (extension host selection) - File count issues affecting activation - Terminal command working directory resolution 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

shanevcantwell · 2025-12-26T13:46:16Z

Before & after for reference. (With PR #9314 fix.) (gpt-oss-20b)

RomneyDa

@shanevcantwell Thanks for the contribution! The only blocking change is the CLAUDE.md note

RomneyDa · 2026-01-06T19:23:00Z

core/tools/implementations/runTerminalCommand.ts

 function resolveWorkingDirectory(workspaceDirs: string[]): string {
+  // Handle vscode-remote://wsl+distro/path URIs (WSL2 remote workspaces)
+  const wslWorkspaceDir = workspaceDirs.find((dir) =>
+    dir.startsWith("vscode-remote://wsl"),


Is there a way we could write this that isn't so specific to vscode-remote://wsl? I suppose the same issue applies to any non-file URIs? If not obvious this is fine for now but it feels a bit specific

Agreed, that was overly narrow. I'll re-submit with it more widely applicable.

RomneyDa · 2026-01-06T19:23:19Z

CLAUDE.md

We use AGENTS.md instead of CLAUDE.md, if any updates are need to AGENTS.md could you make them there?

Oops, that was an oversight to be included at all. Removed.

- Remove WSL-specific check in favor of generic URI handling - Support all vscode-remote:// URI schemes (WSL, SSH, dev-container) - Prefer file:// URIs when available, fall back to remote URIs - Add tests for various remote URI formats - Remove CLAUDE.md per reviewer feedback (use AGENTS.md convention) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

shanevcantwell requested a review from a team as a code owner December 26, 2025 12:06

shanevcantwell requested review from RomneyDa and removed request for a team December 26, 2025 12:06

github-project-automation bot added this to Issues and PRs Dec 26, 2025

github-project-automation bot moved this to Todo in Issues and PRs Dec 26, 2025

dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Dec 26, 2025

cubic-dev-ai bot reviewed Dec 26, 2025

View reviewed changes

dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Dec 26, 2025

cubic-dev-ai bot reviewed Dec 26, 2025

View reviewed changes

core/tools/implementations/runTerminalCommand.ts Outdated Show resolved Hide resolved

shanevcantwell and others added 2 commits December 26, 2025 05:14

dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Dec 26, 2025

cubic-dev-ai bot reviewed Dec 26, 2025

View reviewed changes

core/tools/implementations/resolveWorkingDirectory.vitest.ts Outdated Show resolved Hide resolved

fix: use try/finally for env cleanup in test

27adb1d

Ensures process.env.HOME is restored even if assertions fail, preventing flaky behavior in subsequent tests. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

shanevcantwell mentioned this pull request Dec 26, 2025

Cannot build working VSIX from WSL2 - native binaries mismatch #9326

Open

shanevcantwell and others added 2 commits December 26, 2025 06:22

style: fix prettier formatting

6b30a88

🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

shanevcantwell force-pushed the fix/wsl2-terminal-command-uri branch from d88cbc5 to 6b30a88 Compare December 26, 2025 13:27

shanevcantwell mentioned this pull request Dec 26, 2025

feat: add tool prompt override support in .continuerc.json #9314

Open

5 tasks

RomneyDa requested changes Jan 6, 2026

View reviewed changes

github-project-automation bot moved this from Todo to In Progress in Issues and PRs Jan 6, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: handle non-file URI schemes in runTerminalCommand for WSL2 #9325

fix: handle non-file URI schemes in runTerminalCommand for WSL2 #9325

shanevcantwell commented Dec 26, 2025 •

edited by cubic-dev-ai bot

Loading

Uh oh!

continue bot commented Dec 26, 2025

Uh oh!

cubic-dev-ai bot left a comment

Uh oh!

cubic-dev-ai bot left a comment

Uh oh!

Uh oh!

cubic-dev-ai bot left a comment

Uh oh!

Uh oh!

shanevcantwell commented Dec 26, 2025 •

edited

Loading

Uh oh!

RomneyDa left a comment

Uh oh!

RomneyDa Jan 6, 2026

Uh oh!

shanevcantwell Jan 7, 2026

Uh oh!

RomneyDa Jan 6, 2026

Uh oh!

shanevcantwell Jan 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fix: handle non-file URI schemes in runTerminalCommand for WSL2 #9325

Are you sure you want to change the base?

fix: handle non-file URI schemes in runTerminalCommand for WSL2 #9325

Conversation

shanevcantwell commented Dec 26, 2025 • edited by cubic-dev-ai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Root Cause

Fix

Test plan

Summary by cubic

Uh oh!

continue bot commented Dec 26, 2025

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

shanevcantwell commented Dec 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RomneyDa left a comment

Choose a reason for hiding this comment

Uh oh!

RomneyDa Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

shanevcantwell Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

RomneyDa Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

shanevcantwell Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

shanevcantwell commented Dec 26, 2025 •

edited by cubic-dev-ai bot

Loading

shanevcantwell commented Dec 26, 2025 •

edited

Loading