test(core): fix error message assertions and unskip withExponentialBackoff tests#12530
Open
mian-abd wants to merge 1 commit into
Open
test(core): fix error message assertions and unskip withExponentialBackoff tests#12530mian-abd wants to merge 1 commit into
mian-abd wants to merge 1 commit into
Conversation
Contributor
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
core/util/withExponentialBackoff.tsis the retry helper wrapping every LLM call incore/llm/index.ts(chat fetch + embeddings). Its test file was skipped wholesale viadescribe.skipbecause two assertions used an incorrect expected error string:"Failed to make API call after max tries"is not a substring of the actual implementation message"Failed to make API call after ${maxTries} retries".This PR:
"Failed to make API call after").describe.skipso all 6 existing tests run."overloaded"substring,"malformed json"substring, and"code": 429JSON-body regex.No implementation code is changed.
Checklist
Screen recording or screenshot
N/A — test-only change with no user-visible behavior.
Tests
All changes are in
core/util/withExponentialBackoff.test.ts. Verified locally viacd core && npm test -- withExponentialBackoff— 9 tests pass (6 previously-skipped + 3 new). ESLint and Prettier clean.Summary by cubic
Fixes and re-enables the
withExponentialBackofftest suite, and adds coverage for key retry conditions. Test-only; no runtime changes.Bug Fixes
New Features
"code": 429.Written for commit 8bc8d02. Summary will update on new commits.