fix: stop CLI free-trial polling for non-free-trial models#11215
Open
guoyi-smh wants to merge 3 commits intocontinuedev:mainfrom
Open
fix: stop CLI free-trial polling for non-free-trial models#11215guoyi-smh wants to merge 3 commits intocontinuedev:mainfrom
guoyi-smh wants to merge 3 commits intocontinuedev:mainfrom
Conversation
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
There was a problem hiding this comment.
No issues found across 2 files
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Add one-off context when rerunning by tagging
@cubic-dev-aiwith guidance or docs links (includingllms.txt) - Ask questions if you need clarification on any suggestion
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #11214.
Validation
Notes
Summary by cubic
Stops the CLI from fetching or polling free‑trial status for non‑free‑trial models. Keeps immediate fetch and 5s polling only for free‑trial
continue-proxymodels, and skips installing Remote-* marketplace extensions in VS Code E2E whenIGNORE_SSH_TESTS=true. Closes #11214.isModelUsingFreeTrial(model); add mounted checks and skip polling in test env.extensions/vscode/e2e/install-marketplace-extensions.mjsand updatee2e:install-extensionsto honorIGNORE_SSH_TESTS=true.Written for commit e5c8a67. Summary will update on new commits.