Skip to content

fix: stop CLI free-trial polling for non-free-trial models#11215

Open
guoyi-smh wants to merge 3 commits intocontinuedev:mainfrom
guoyi-smh:codex/cli-disable-free-trial-polling
Open

fix: stop CLI free-trial polling for non-free-trial models#11215
guoyi-smh wants to merge 3 commits intocontinuedev:mainfrom
guoyi-smh:codex/cli-disable-free-trial-polling

Conversation

@guoyi-smh
Copy link

@guoyi-smh guoyi-smh commented Mar 9, 2026

Summary

  • gate the CLI free-trial status fetch/polling behind an actual free-trial model check
  • keep the existing 5 second polling behavior only for free-trial continue-proxy models
  • add a focused UI test covering both the non-free-trial and free-trial paths

Closes #11214.

Validation

  • ./node_modules/.bin/vitest run src/ui/FreeTrialStatus.test.tsx
  • ./node_modules/.bin/eslint src/ui/FreeTrialStatus.tsx src/ui/FreeTrialStatus.test.tsx

Notes

  • I installed dependencies locally in extensions/cli to run the focused test.
  • A full npm install currently trips the package prepare build in this checkout because sibling workspace packages are not built, so validation stayed scoped to the touched files.

Summary by cubic

Stops the CLI from fetching or polling free‑trial status for non‑free‑trial models. Keeps immediate fetch and 5s polling only for free‑trial continue-proxy models, and skips installing Remote-* marketplace extensions in VS Code E2E when IGNORE_SSH_TESTS=true. Closes #11214.

  • Bug Fixes
    • Gate initial fetch/polling to free‑trial models via isModelUsingFreeTrial(model); add mounted checks and skip polling in test env.
    • Add focused UI tests for non‑free‑trial and free‑trial paths, including polling cadence.
    • Add extensions/vscode/e2e/install-marketplace-extensions.mjs and update e2e:install-extensions to honor IGNORE_SSH_TESTS=true.

Written for commit e5c8a67. Summary will update on new commits.

@guoyi-smh guoyi-smh requested a review from a team as a code owner March 9, 2026 02:43
@guoyi-smh guoyi-smh requested review from RomneyDa and removed request for a team March 9, 2026 02:43
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Mar 9, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2026

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files


Since this is your first cubic review, here's how it works:

  • cubic automatically reviews your code and comments on bugs and improvements
  • Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
  • Add one-off context when rerunning by tagging @cubic-dev-ai with guidance or docs links (including llms.txt)
  • Ask questions if you need clarification on any suggestion

@guoyi-smh
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

CLI polls free-trial status every 5s even when no free-trial model is active

1 participant