Avoid sending orphaned reasoning items to OpenAI Responses API#11140
Open
siewcapital wants to merge 1 commit intocontinuedev:mainfrom
Open
Avoid sending orphaned reasoning items to OpenAI Responses API#11140siewcapital wants to merge 1 commit intocontinuedev:mainfrom
siewcapital wants to merge 1 commit intocontinuedev:mainfrom
Conversation
Contributor
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- only include messages in when a later assistant message exists\n- skip trailing/orphaned reasoning items so we don't send invalid entries without the required follow-up item\n- add regression tests that cover both skipped trailing reasoning and preserved reasoning before assistant output\n\n## Testing\n- undefined
ERR_PNPM_RECURSIVE_EXEC_FIRST_FAIL Command "vitest" not found (fails in this environment: )\n\nCloses #11138
Continue Tasks: 🔄 7 running — View all
Summary by cubic
Stops sending orphaned reasoning items to the OpenAI Responses API by only including “thinking” entries when followed by an assistant message. Prevents invalid input and enforces correct item order. Fixes #11138.
Written for commit d90c504. Summary will update on new commits.