feat(cli): add onboarding with openai as option#11111
Open
uinstinct wants to merge 4 commits intocontinuedev:mainfrom
Open
feat(cli): add onboarding with openai as option#11111uinstinct wants to merge 4 commits intocontinuedev:mainfrom
uinstinct wants to merge 4 commits intocontinuedev:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
3 issues found across 5 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="extensions/cli/src/onboarding.ts">
<violation number="1" location="extensions/cli/src/onboarding.ts:114">
P1: Custom agent: **Don't use console.log**
New console logging was added; replace these with the project logger to comply with the "Don't use console.log" rule.</violation>
</file>
<file name="extensions/cli/src/util/apiKeyValidation.ts">
<violation number="1" location="extensions/cli/src/util/apiKeyValidation.ts:22">
P2: OpenAI API key validation is overly permissive and can incorrectly accept Anthropic keys (sk-ant-...), leading to false-positive onboarding validation. The `startsWith("sk-")` check will match Anthropic keys since they also start with "sk-", causing provider-mismatch errors when the key is later used with OpenAI APIs.</violation>
</file>
<file name="extensions/cli/spec/onboarding.md">
<violation number="1" location="extensions/cli/spec/onboarding.md:34">
P2: Spec documents stale `uses:` schema that conflicts with actual onboarding implementation. The spec shows `uses: openai/gpt-5.4` with `with:` blocks, but the CLI onboarding writes local model configs. Users following this documentation will create invalid configs.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
usesAI Code Review
@continue-reviewChecklist
Screen recording or screenshot
[ When applicable, please include a short screen recording or screenshot - this makes it much easier for us as contributors to review and understand your changes. See this PR as a good example. ]
Tests
[ What tests were added or updated to ensure the changes work as expected? ]
Continue Tasks: 🔄 7 running — View all
Summary by cubic
Adds OpenAI (GPT 5.4) to CLI onboarding and removes “Log in with Continue”. The flow writes local model entries to ~/.continue/config.yaml and validates Anthropic and OpenAI keys.
New Features
gpt-5.4to config.ANTHROPIC_API_KEY.Refactors
Written for commit a48d9ec. Summary will update on new commits.