Conversation
Three session commits (65743e8, 5cab1c2, 2a94003) bypassed review and the required CI gates because branch protection does not enforce rules on administrators (enforce_admins=false). Make the policy explicit in AGENTS.md: all work - code, CI, docs, tooling - lands via branch + PR; AI agents open the PR and stop; merging is the maintainer's call. Signed-off-by: Jonathan Springer <jps@s390x.com>
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Process change requested directly by the maintainer after three session commits (
65743e8,5cab1c2,2a94003) landed onmainwithout review.Summary
Make the no-direct-push policy explicit in
AGENTS.md:main— no exceptions for maintainers, admins, or AI agents. Every change (code, tests, CI, docs, tooling) lands on a branch and merges via PR; direct pushes bypass review and the required CI gates.main, even when asked to "ship"/"deliver"/"publish".Root cause enabling the bypass: branch protection has
enforce_admins=false, so administrators skip all 5 required status checks. Recommended follow-up (repo settings, not this PR): enable Include administrators formainso the rules bind everyone. Withrequired_approving_review_count=0(solo-maintainer friendly) PRs remain self-mergeable while still running the CI gates.Reviewability
triageType of Change
Verification
pytestruff check .mypy src/Manual: rendered diff reviewed; markdown structure matches the existing
## Contribution workflowsection style.Checklist
pytestpasses (N/A docs-only)ruff check .andmypy src/are green (N/A docs-only)git commit -s, DCO)