Conversation
…server catalog page Signed-off-by: Marek Dano <mk.dano@gmail.com>
…it tests Signed-off-by: Marek Dano <mk.dano@gmail.com>
a-effort
marked this pull request as ready for review
September 17, 2026 20:36
a-effort
force-pushed
the
catalog-icon-tile-tokens
branch
from
September 17, 2026 20:38
a9e2cd2 to
3797033
Compare
… is missing Adds --catalog-icon-tile and --catalog-icon-backing so the tile and the light patch behind dark glyphs follow the theme by name instead of reusing bg-muted and bg-neutral-100. The light-mode tile moves from oklch(0.97) to white and the dark-mode backing softens from neutral-100 to neutral-300. Catalog entries with no bundled logo now render the MCP mark on that same tile rather than a name-hashed brand colour, so every card reads as one surface. Restores the overflow-hidden that the rounded tile was added for. Signed-off-by: Anna Effort <anna.effort@ibm.com>
a-effort
force-pushed
the
catalog-icon-tile-tokens
branch
from
September 17, 2026 20:40
3797033 to
9fc1479
Compare
a-effort
changed the title
There was a problem hiding this comment.
🟢 Approval recommended
The focused visual changes are consistent with the stated requirements and adequately covered by updated tests.
Pull request overview
Adds theme-aware catalog icon tiles, improved dark-logo backing, and an MCP fallback mark.
Changes:
- Introduces catalog icon color tokens for light and dark themes.
- Updates catalog logos with clipping, backing, and fallback behavior.
- Adjusts tests and shared API mocks accordingly.
File summaries
| File | Description |
|---|---|
src/components/server-catalog/CatalogLogo.tsx |
Implements the revised icon tile and fallback. |
src/index.css |
Adds theme-aware catalog icon tokens. |
src/components/server-catalog/CatalogResults.test.tsx |
Tests tile and backing behavior. |
src/pages/ServerCatalog.test.tsx |
Updates fallback assertions. |
src/test/mocks/handlers.ts |
Adds default tag and permission handlers. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
a-effort
requested review from
gandhipratik203,
gcgoncalves,
marekdano and
vishu-bh
September 17, 2026 20:49
marekdano
approved these changes
Sep 18, 2026
marekdano
left a comment
marekdano
left a comment
Contributor
There was a problem hiding this comment.
Solid, small, well-scoped change.
LGTM 🚀
gcgoncalves
approved these changes
Sep 18, 2026
gcgoncalves
reviewed
Sep 18, 2026
Comment on lines
+9
to
+10
| const TILE = | ||
| "flex size-8 shrink-0 items-center justify-center overflow-hidden rounded-md bg-catalog-icon-tile p-2 shadow-xs"; |
Contributor
There was a problem hiding this comment.
Nice touch here, great way to ensure consistency between the tiles and preventing someone from accidentally updating one of the logo types! 👏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #132.
Adds
--catalog-icon-tileand--catalog-icon-backing, replacingbg-mutedandbg-neutral-100inCatalogLogo:Notes:
ServerIcon, which picked a background by hashing the server name.ServerIconis unchanged and still used elsewhere.overflow-hiddendropped in 9d8ef94.ServerCatalog.test.tsxusedServerIcon'saria-labelto detect the fallback. That label is gone, so they assert the tile and its mark instead.Stacked on #132, so the diff includes its two commits. Will rebase onto main once it merges.