Conversation
embedded_metadata and ai_generated_metadata are not supported on dev11 CDA — API returns HTTP 422. Restrict assetFields() calls to the two supported values (user_defined_fields, visual_markups) in asset.spec.ts, asset-query.spec.ts, entries.spec.ts, and entry.spec.ts. Generated by Claude Code
fix: remove unsupported asset_fields params from CDA API tests
Fix back merge
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
🔒 Security Scan Results
⏱️ SLA Breach Summary
ℹ️ Vulnerabilities Without Available Fixes (Informational Only)The following vulnerabilities were detected but do not have fixes available (no upgrade or patch). These are excluded from failure thresholds:
✅ BUILD PASSED - All security checks passed |
Coverage report
Test suite run success720 tests passing in 36 suites. Report generated by 🧪jest coverage report action from 1b8fb20 |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Documented asset-field options lose their only live CDA coverage across four API paths.
Review effort: Balanced
Findings: 4
Open (4)
What changed in this PR
Updates release dependencies and narrows API tests for asset-field parameters.
Changes:
- Upgrades Axios and Playwright.
- Refreshes transitive dependency locks.
- Removes two documented asset-field values from API tests.
| File | Description |
|---|---|
test/api/entry.spec.ts |
Narrows entry asset-field coverage. |
test/api/entries.spec.ts |
Narrows entries asset-field coverage. |
test/api/asset.spec.ts |
Narrows asset fetch coverage. |
test/api/asset-query.spec.ts |
Narrows asset query coverage. |
package.json |
Upgrades Axios and Playwright. |
package-lock.json |
Locks updated dependency graph. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| it("should query assets with asset_fields[] CDA param (user_defined_fields, visual_markups)", async () => { | ||
| const result = await makeAssetQuery() | ||
| .assetFields("user_defined_fields", "embedded_metadata", "ai_generated_metadata", "visual_markups") | ||
| .assetFields("user_defined_fields", "visual_markups") |
| it('should fetch asset with asset_fields[] CDA param (user_defined_fields, visual_markups)', async () => { | ||
| const result = await makeAsset(assetUid) | ||
| .assetFields('user_defined_fields', 'embedded_metadata', 'ai_generated_metadata', 'visual_markups') | ||
| .assetFields('user_defined_fields', 'visual_markups') |
| it("should query entries with asset_fields[] CDA param (user_defined_fields, visual_markups)", async () => { | ||
| const result = await makeEntries(BLOG_POST_CT) | ||
| .assetFields("user_defined_fields", "embedded_metadata", "ai_generated_metadata", "visual_markups") | ||
| .assetFields("user_defined_fields", "visual_markups") |
| it('should fetch entry with asset_fields[] CDA param (user_defined_fields, visual_markups)', async () => { | ||
| const result = await makeEntry(entryUid) | ||
| .assetFields('user_defined_fields', 'embedded_metadata', 'ai_generated_metadata', 'visual_markups') | ||
| .assetFields('user_defined_fields', 'visual_markups') |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.