Introduce Contentpass layer and OneTrust CMP adapters

[0x7f]

No description provided.

[slawomirzaba]

cleaner:

useEffect(() => {
  const initCmp = async () => {
    try {
      await OTPublishersNativeSDK.startSDK(
        ONETRUST_CDN_LOCATION,
        ONETRUST_APP_ID,
        ONETRUST_LANGUAGE_CODE,
        {},
        false
      );

      const onetrustCmpAdapter: CmpAdapter =
        await createOnetrustCmpAdapter(OTPublishersNativeSDK);

      setCmpAdapter(onetrustCmpAdapter);
      setCmpReady(true);
    } catch (error: any) {
      console.error('Failed to initialize CMP', error);
      setCmpFailed(true);
    }
  };

  initCmp();
}, []);

[slawomirzaba]

maybe cleaner to have just type CmpStatus = 'loading' | 'ready' | 'error';

and
const [status, setStatus] = useState('loading'); ad cmpFailed and cmpAdapter can be removed?

and then:

  if (status === 'loading') {
    return (
      <View style={styles.container}>
        <Text>Loading CMP...</Text>
      </View>
    );
  }

  if (status === 'error' || !cmpAdapter) {
    return (
      <View style={styles.container}>
        <Text>Failed to load CMP</Text>
      </View>
    );
  }

[slawomirzaba]

no need for explanation mark with if above

[slawomirzaba]

the same here

[slawomirzaba]

nit: ContentpassSdkProvider could expose contentpassConfig so no need to pass it to ContentpassConsentGate

[slawomirzaba]

do we need to have isShowingSecondLayer and isShowingContentpass as separated states? Is it possible for example to have them true in the same time? Maybe we could have one state with enum for it?

[slawomirzaba]

invalidStates doesn't have to be in effect

[slawomirzaba]

this whole useEffect is complex and not needed. We can remove:
const [isVisible, setIsVisible] = useState(false);

calculate isVisible in memo:

const isVisible = useMemo(() => {
  const invalidStates = [
    ContentpassStateType.INITIALISING,
    ContentpassStateType.ERROR,
  ];

  if (!cmpReady || !cpAuthState || invalidStates.includes(cpAuthState.state)) {
    return false;
  }

  if (isShowingSecondLayer || isShowingContentpass) {
    return false; 
  }

  const isFine =
    cpAuthState.state === ContentpassStateType.AUTHENTICATED || hasFullConsent;

  return !isFine;
}, [
  cmpReady,
  cpAuthState,
  hasFullConsent,
  isShowingSecondLayer,
  isShowingContentpass,
]);

have prev visibility on ref : const prevVisibleRef = React.useRef<boolean | null>(null);

and then simplify effect to:

useEffect(() => {
  if (prevVisibleRef.current === null) {
    prevVisibleRef.current = isVisible;
    return;
  }
  if (prevVisibleRef.current !== isVisible) {
    prevVisibleRef.current = isVisible;
    onVisibilityChange?.(isVisible);
  }
}, [isVisible, onVisibilityChange]);

[slawomirzaba]

shoudn;t we recalculate it after consent changes?

[slawomirzaba]

renderContentpassLayer() is a function declared on every render; Would be better to extract it to separated compnent