fix(secrets): replace using correct driver, safe replace for new secrets #548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When replacing an existing secret, the delete operation should ran on the old driver, which is not necessarily the new one. When replacing a nonexisting secret (Replace=true), ignore the replace flag, treat it as an entirely new secret. (previous behavior: would attempt to delete a secret whose name or id matches an empty string query, which either failed due to ambiguity or successfully deleted an existing secret if exactly 1 secret was present) Solves issues 1 and 2 of containers/podman#27130 Signed-off-by: Samuel Gunter <sgunter@utexas.edu>
podmanbot
pushed a commit
to podmanbot/buildah
that referenced
this pull request
Dec 10, 2025
|
✅ A new PR has been created in buildah to vendor these changes: containers/buildah#6590 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When replacing an existing secret, the delete operation should ran on the old driver, which is not necessarily the new one.
When replacing a nonexisting secret (Replace=true), ignore the replace flag, treat it as an entirely new secret. (previous behavior: would attempt to delete a secret whose name or id matches an empty string query, which either failed due to ambiguity or successfully deleted an existing secret if exactly 1 secret was present)
Solves issues 1 and 2 of containers/podman#27130