fix(bwrap): honor namespace fd 0#731
Open
danielchristiancazares wants to merge 1 commit intocontainers:mainfrom
Open
fix(bwrap): honor namespace fd 0#731danielchristiancazares wants to merge 1 commit intocontainers:mainfrom
danielchristiancazares wants to merge 1 commit intocontainers:mainfrom
Conversation
Use -1 sentinel checks for --userns, --userns2, and --pidns so fd 0 is treated as a valid descriptor consistently.
swick
reviewed
Feb 23, 2026
|
|
||
| /* Switch to the custom user ns before the clone, gets us privs in that ns (assuming its a child of the current and thus allowed) */ | ||
| if (opt_userns_fd > 0 && setns (opt_userns_fd, CLONE_NEWUSER) != 0) | ||
| if (opt_userns_fd != -1 && setns (opt_userns_fd, CLONE_NEWUSER) != 0) |
Contributor
There was a problem hiding this comment.
Let's use >= 0 because this really is what makes the fd valid.
There was a problem hiding this comment.
Every other check uses != -1. Unexpected invalid fds failing loudly seems like an upside.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary