Skip to content

fix(bwrap): close pdeathsig parent race #730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
danielchristiancazares wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −1
Open

fix(bwrap): close pdeathsig parent race #730

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion bubblewrap.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,8 +383,21 @@ usage (int ecode, FILE *out)
static void
handle_die_with_parent (void)
{
if (opt_die_with_parent && prctl (PR_SET_PDEATHSIG, SIGKILL, 0, 0, 0) != 0)
pid_t ppid;

if (!opt_die_with_parent)
return;

ppid = getppid ();
if (prctl (PR_SET_PDEATHSIG, SIGKILL, 0, 0, 0) != 0)
die_with_error ("prctl");

/* Close the race where our parent exits before PR_SET_PDEATHSIG takes effect. */
if (getppid () != ppid)
{
(void) kill (getpid (), SIGKILL);
_exit (1);
}
}

static void
Expand Down