-
Notifications
You must be signed in to change notification settings - Fork 738
add MAC, IPv4, IPv6 addresses to nework inspect #4680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
coderbirju
wants to merge
1
commit into
containerd:main
Choose a base branch
from
coderbirju:add-details-network-inspect
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2385db1 to
eb356cf
Compare
haytok
reviewed
Jan 10, 2026
eb356cf to
365205b
Compare
Contributor
Author
|
Apologies for the late reply, you're right we can skip the assert statements as the field existence is already validated through struct unmarshaling. |
haytok
reviewed
Feb 1, 2026
| Command: func(data test.Data, helpers test.Helpers) test.TestableCommand { | ||
| return helpers.Command("network", "inspect", data.Identifier("test-network")) | ||
| }, | ||
| Expected: func(data test.Data, helpers test.Helpers) *test.Expected { |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are no tests for the items added in this PR's changes. Should add assertions for IPv4Address, MacAddress, and IPv6Address.
Signed-off-by: Arjun Raja Yogidas <arjunry@amazon.com>
365205b to
0756765
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current network inspect respone provides only container names
This PR adds other fields in the EndpointResource Struct
Testing:
CIDR Notation:
Result
Multi-Network Container:
-hoge
-fuga