Skip to content

ci: update actions and golangci-lint for go1.27, pin actions by sha - #26

Merged
AkihiroSuda merged 2 commits into
containerd:mainfrom
thaJeztah:fix_ci
Aug 23, 2026
Merged

ci: update actions and golangci-lint for go1.27, pin actions by sha#26
AkihiroSuda merged 2 commits into
containerd:mainfrom
thaJeztah:fix_ci

Conversation

@thaJeztah

Copy link
Copy Markdown
Member

ci: update actions and golangci-lint for go1.27

The current golangci-lint version isn't compatible with go1.27;

run golangci-lint
  Running [/home/runner/golangci-lint-2.12.2-linux-amd64/golangci-lint config path] in [/home/runner/work/log/log] ...
  Running [/home/runner/golangci-lint-2.12.2-linux-amd64/golangci-lint config verify] in [/home/runner/work/log/log] ...
  Running [/home/runner/golangci-lint-2.12.2-linux-amd64/golangci-lint run] in [/home/runner/work/log/log] ...
  Error: ../../../../../opt/hostedtoolcache/go/1.27.0/x64/src/internal/poll/splice_linux.go:237:21: unknown field rfd in struct literal of type splicePipe (typecheck)
    return &splicePipe{rfd: fds[0], wfd: fds[1]}
                       ^

ci: pin actions by sha and set dependabot cooldown

The current golangci-lint version isn't compatible with go1.27;

    run golangci-lint
      Running [/home/runner/golangci-lint-2.12.2-linux-amd64/golangci-lint config path] in [/home/runner/work/log/log] ...
      Running [/home/runner/golangci-lint-2.12.2-linux-amd64/golangci-lint config verify] in [/home/runner/work/log/log] ...
      Running [/home/runner/golangci-lint-2.12.2-linux-amd64/golangci-lint run] in [/home/runner/work/log/log] ...
      Error: ../../../../../opt/hostedtoolcache/go/1.27.0/x64/src/internal/poll/splice_linux.go:237:21: unknown field rfd in struct literal of type splicePipe (typecheck)
        return &splicePipe{rfd: fds[0], wfd: fds[1]}
                           ^

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates CI tooling for Go 1.27 compatibility and improves GitHub Actions dependency stability.

Changes:

  • Upgrades golangci-lint to v2.13 and configures its timeout.
  • Pins workflow actions to immutable commit SHAs.
  • Adds a seven-day Dependabot cooldown.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
.golangci.yml Configures the linter timeout.
.github/workflows/ci.yml Updates lint tooling and pins CI actions.
.github/dependabot.yml Adds Dependabot cooldown configuration.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@AkihiroSuda
AkihiroSuda merged commit 9354588 into containerd:main Aug 23, 2026
7 checks passed
@thaJeztah
thaJeztah deleted the fix_ci branch August 23, 2026 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants