Add support for using slog for log output#12
Open
dmcgowan wants to merge 1 commit intocontainerd:mainfrom
Open
Add support for using slog for log output#12dmcgowan wants to merge 1 commit intocontainerd:mainfrom
dmcgowan wants to merge 1 commit intocontainerd:mainfrom
Conversation
Allows containerd logs to use the default slog logger if configured. Ensures that when formatting is set, such as through a default configuration, if the slog format as well previously set. Signed-off-by: Derek McGowan <derek@mcg.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows containerd logs to use the default slog logger if configured. Ensures that when formatting is set, such as through a default configuration, the slog format as well previously set.
Related to #2
This is only addressing compatibility with slog to allow a transition without breaking existing logs or support importing into a project which is using slog. I don't think we still have a good API design to wrap slog or plan for how we want to translate our current use of this library to slog. We could always have a "v2" of this library which just uses slog Logger over logrus Logger, but I think the ideal outcome is we deprecate this library in the future in favor of slog. There is very little functionality this library adds on top of slog.