Conversation
|
Review complete. No issues found — approved ✅. This PR enhances the
No defects exceeded the reporting threshold after adjudication; the conditional spreads, native Reviewed commit: 0b47e76 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parse()returned a classification without indicating whether the producer supplied it or the registry supplied the default. Adapters such as constructive-db storage therefore had to inspect DETAIL/GraphQL fields again to retain their own default for undeclared classifications.This adds optional
ParsedError.explicitClassmetadata from the valid producer classification the parser actually used. It covers canonical errors, PostgreSQL DETAIL and GraphQL extensions while preserving the existing precedence, registry defaults, HTTP hints, messages and wrapping behavior. The README explains that the metadata describes the immediate input and shows how adapters can use it.Validation:
git diff --checkpassed.Supports the classification-parser cleanup in constructive-db #3656 once this API is released.