Remove unnecessary secrets: inherit from auto-merge caller - #258
Conversation
The shared auto-merge reusable workflow uses only the automatic GITHUB_TOKEN, which is provided to reusable workflows without secrets: inherit. Passing secrets: inherit therefore forwards all of this repository's secrets to the shared workflow for no functional benefit, widening the blast radius if that shared workflow were ever compromised. The reusable workflow is already pinned to a commit SHA, and the caller's own permissions block (contents: write, pull-requests: write) is unchanged, so auto-merge behavior is unaffected. Signed-off-by: Rob Nester <rnester@redhat.com> Ref: EC-2051
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. 📝 WalkthroughWalkthroughThe auto-merge workflow job no longer inherits repository secrets from the caller workflow. Its pull-request and contents write permissions remain configured. ChangesAuto-merge permissions
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to The change removes unnecessary secret exposure while retaining the stated auto-merge permissions; no merge-blocking risk is identified in the supplied context. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
PR Summary by QodoStop forwarding repository secrets to auto-merge workflow
AI Description
High-Level Assessment
Files changed (1)
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can route each action level your way: inline, summary, both, or drop |
|
Risk Assessment: moderate (2/5) DetailsSingle-line deletion from a CI workflow that removes an overly broad secrets permission; CI_WORKFLOW_CHANGED and a protected path lift the score to moderate, but the minimal scope, single author, no revert history, and high rollback safety cap the risk at 2. |
|
Looks good to me
|
The shared auto-merge reusable workflow uses only the automatic GITHUB_TOKEN, which is provided to reusable workflows without secrets: inherit. Passing secrets: inherit therefore forwards all of this repository's secrets to the shared workflow for no functional benefit, widening the blast radius if that shared workflow were ever compromised.
The reusable workflow is already pinned to a commit SHA, and the caller's own permissions block (contents: write, pull-requests: write) is unchanged, so auto-merge behavior is unaffected.
Signed-off-by: Rob Nester rnester@redhat.com
Ref: EC-2051