[NOGIL] Fix Producer.close() races with concurrent calls and with itself#2313
Open
Ojasva Jain (ojasvajain) wants to merge 4 commits into
Open
[NOGIL] Fix Producer.close() races with concurrent calls and with itself#2313Ojasva Jain (ojasvajain) wants to merge 4 commits into
Ojasva Jain (ojasvajain) wants to merge 4 commits into
Conversation
Ojasva Jain (ojasvajain)
requested review from
a team and
Matthew Seal (MSeal)
as code owners
July 21, 2026 13:52
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
Producer.close() previously raced with concurrent produce()/poll()/ flush()/produce_batch()/transaction calls and with itself when called from multiple threads, both leading to use-after-free/double-free on the underlying rd_kafka_t handle. Adds an active_calls/closing guard (Handle_enter_rk_use/Handle_exit_rk_use) so every method that touches self->rk registers itself before use, and close() drains in-flight calls before tearing down; a CAS on `closing` ensures only one concurrent close() call performs the actual teardown, with losing callers waiting for it to finish rather than racing it. Adds tests/parallel/test_producer_close_race.py covering each affected method racing close(), close() racing itself, and close()'s blocking behavior. Uses pytest-forked (POSIX only) so a regression segfault fails only that test. Integration tests against a real broker are still pending.
…for Producer close()/transaction races
airlock-confluentinc
Bot
force-pushed
the
dev_producer_no_gil
branch
from
July 23, 2026 11:37
f1bd331 to
4c936db
Compare
airlock-confluentinc
Bot
force-pushed
the
dev_thread_free_support
branch
from
July 23, 2026 11:39
386d71a to
39740bd
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Producer.close()previously raced with concurrent produce()/poll()/ flush()/produce_batch()/transaction calls and with itself when called from multiple threads, both leading to use-after-free/double-free on the underlying rd_kafka_t handle.This PR adds:
An active_calls/closing guard (Handle_enter_rk_use/Handle_exit_rk_use) so every method that touches self->rk registers itself before use, and close() drains in-flight calls before tearing down;
A CAS on
closingensures only one concurrent close() call performs the actual teardown, with losing callers waiting for it to finish rather than racing it.Unit and integration test cases
What
Checklist
References
JIRA:
Test & Review
Open questions / Follow-ups