Skip to content

on_config_changed lock fix: recursive lock in configservice #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kp-cat merged 1 commit into from
Mar 10, 2026
+12 −2
Merged

on_config_changed lock fix: recursive lock in configservice #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions configcatclient/configservice.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import hashlib
from threading import Thread, Event, Lock
from threading import Thread, Event, RLock

from . import utils
from .config import FEATURE_FLAGS, CONFIG_FILE_NAME, SERIALIZATION_FORMAT_VERSION
Expand All @@ -21,7 +21,7 @@ def __init__(self, sdk_key, polling_mode, hooks, config_fetcher, log, config_cac
self._is_offline = is_offline
self._response_future = None
self._initialized = Event()
self._lock = Lock()
self._lock = RLock()
self._ongoing_fetch = False
self._fetch_finished = Event()
self._start_time = utils.get_utc_now()
Expand Down
10 changes: 10 additions & 0 deletions configcatclienttests/test_hooks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,16 @@ def test_callback_exception(self):
value = client.get_value('', 'default')
self.assertEqual('default', value)

def test_callback_config_changed(self):
def on_flag_changed(config):
value = client.get_value('testStringKey', '')
self.assertEqual(TEST_OBJECT[FEATURE_FLAGS]['testStringKey'], value)

hooks = Hooks(on_config_changed=on_flag_changed)
config_cache = ConfigCacheMock()
client = ConfigCatClient.get(TEST_SDK_KEY, ConfigCatOptions(polling_mode=PollingMode.manual_poll(), config_cache=config_cache, hooks=hooks))
client.force_refresh()


if __name__ == '__main__':
unittest.main()
Loading