Skip to content

Fix config change hook initialization and add test #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
novalisdenahi merged 2 commits into from
Oct 14, 2026
Merged

Fix config change hook initialization and add test #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dcc0002
Fix config change hook initialization and add test
novalisdenahi Oct 12, 2026
5204d1f
Extend UserAttributeConvertTest with String Array/List contains null …
novalisdenahi Oct 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/main/java/com/configcat/ConfigService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,11 @@ public ConfigService(String sdkKey,

} else {
// Sync up with cache before reporting ready state
cachedEntry.set(readCache());
Entry fromCache = readCache();
if (!fromCache.isEmpty() && !fromCache.getETag().equals(cachedEntry.get().getETag())){
cachedEntry.set(fromCache);
configCatHooks.invokeOnConfigChanged(fromCache.getConfig().getEntries());
}
setInitialized();
}
}
Expand Down
4 changes: 4 additions & 0 deletions src/test/java/com/configcat/ConfigCatClientTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -910,14 +910,18 @@ void testHooksSub() throws IOException {
void testReadyHookManualPollWithCache() throws IOException {

AtomicReference<ClientCacheState> ready = new AtomicReference<>(null);
AtomicBoolean changed = new AtomicBoolean(false);

ConfigCache cache = new SingleValueCache(Helpers.cacheValueFromConfigJson(String.format(TEST_JSON, "test")));

ConfigCatClient cl = ConfigCatClient.get(Helpers.SDK_KEY, options -> {
options.pollingMode(PollingModes.manualPoll());
options.cache(cache);
options.hooks().addOnConfigChanged(map -> changed.set(true));
options.hooks().addOnClientReady(ready::set);
});

assertTrue(changed.get());
assertEquals(ClientCacheState.HAS_CACHED_FLAG_DATA_ONLY, ready.get());

cl.close();
Expand Down
2 changes: 2 additions & 0 deletions src/test/java/com/configcat/UserAttributeConvertTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,10 @@ private static Stream<Arguments> testDataForUserTest() {
//String Array data
Arguments.of("configcat-sdk-1/JcPbCGl_1E-K9M-fJOyKyQ/OfQqcTjfFUGBwMKqtyEOrQ", "stringArrayContainsAnyOfDogDefaultCat", String.class, new String[]{"x", "read"}, "Dog"),
Arguments.of("configcat-sdk-1/JcPbCGl_1E-K9M-fJOyKyQ/OfQqcTjfFUGBwMKqtyEOrQ", "stringArrayContainsAnyOfDogDefaultCat", String.class, new String[]{"x", "Read"}, "Cat"),
Arguments.of("configcat-sdk-1/JcPbCGl_1E-K9M-fJOyKyQ/OfQqcTjfFUGBwMKqtyEOrQ", "stringArrayContainsAnyOfDogDefaultCat", String.class, new String[]{"x", "read", null}, "Cat"),
Arguments.of("configcat-sdk-1/JcPbCGl_1E-K9M-fJOyKyQ/OfQqcTjfFUGBwMKqtyEOrQ", "stringArrayContainsAnyOfDogDefaultCat", String.class, Arrays.asList("x", "read"), "Dog"),
Arguments.of("configcat-sdk-1/JcPbCGl_1E-K9M-fJOyKyQ/OfQqcTjfFUGBwMKqtyEOrQ", "stringArrayContainsAnyOfDogDefaultCat", String.class, Arrays.asList("x", "Read"), "Cat"),
Arguments.of("configcat-sdk-1/JcPbCGl_1E-K9M-fJOyKyQ/OfQqcTjfFUGBwMKqtyEOrQ", "stringArrayContainsAnyOfDogDefaultCat", String.class, Arrays.asList("x", "read", null), "Cat"),
Arguments.of("configcat-sdk-1/JcPbCGl_1E-K9M-fJOyKyQ/OfQqcTjfFUGBwMKqtyEOrQ", "stringArrayContainsAnyOfDogDefaultCat", String.class, "[\"x\", \"read\"]", "Dog"),
Arguments.of("configcat-sdk-1/JcPbCGl_1E-K9M-fJOyKyQ/OfQqcTjfFUGBwMKqtyEOrQ", "stringArrayContainsAnyOfDogDefaultCat", String.class, "[\"x\", \"Read\"]", "Cat"),
Arguments.of("configcat-sdk-1/JcPbCGl_1E-K9M-fJOyKyQ/OfQqcTjfFUGBwMKqtyEOrQ", "stringArrayContainsAnyOfDogDefaultCat", String.class, "x, read", "Cat"),
Expand Down
Loading