security update: httpoison#150
Open
kp-cat wants to merge 13 commits into
Open
Conversation
laliconfigcat
approved these changes
Jun 18, 2026
|
Hey folks 👋🏼 Keen on bumping configcat to a version that doesn't rely on the problematic HTTPoison. Any idea when this will land? |
laliconfigcat
requested changes
Jul 2, 2026
laliconfigcat
left a comment
laliconfigcat
left a comment
Member
There was a problem hiding this comment.
Sorry, for taking so long to respond.
It seems to me that the tests are failing. Could you please check them?
kp-cat
force-pushed
the
secu-update-202606
branch
from
a268c3c to
53c0d7b
Compare
kp-cat
force-pushed
the
secu-update-202606
branch
from
53c0d7b to
3528ce5
Compare
`preferred_cli_env` was deprecated as of Elixir 1.15, and we've now moved past that version.
This fixes a new compiler warning in Elixir 1.20.
When we generate tests in a `for` loop, it generates individual tests with values hard-coded into the test body. The Elixir 1.20 type-checker knows the exact type of each value, so gives us warnings when we have conditional code that works for all of the possible values. The workaround is to put the test values into `@tag`s and then extract them from the test context. For consistency, we modify all table-driven tests to use the `@tag`/test context pattern.
The newer version of dialyzer caught some type errors that it missed before, so we fix those. HTTPoison 3.0 also has some type errors of its own which we ignore until [this upstream PR](edgurgel/httpoison#511) is merged and released (or we migrate away from HTTPoison).
Different Elixir versions find different problems, so a filter that's needed in Elixir 1.17 and above may not be needed in Elixir 1.16.
Just commenting out the `true` version didn't appear to be enough.
Some of the message wording has changed from version to version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the purpose of your pull request
Related issues (only if applicable)
Security (only if applicable)
(atom-table exhaustion via URL schemes, HTTP header injection, WebSocket buffer limits and more)" — this is almost certainly the high-severity vuln Snyk flagged.
Requirement checklist (only if applicable)