fix: prevent panic on thread if no mount is selected#47
Merged
conaticus merged 3 commits intoconaticus:devfrom Jul 1, 2023
Merged
fix: prevent panic on thread if no mount is selected#47conaticus merged 3 commits intoconaticus:devfrom
conaticus merged 3 commits intoconaticus:devfrom
Conversation
Owner
|
Thanks, I moved this to the client side and sent an alert if search was attempted outside of volume. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a simple fix
You can see the bug if you try to search before selecting a drive,
the drive is set to "" and an unwrap none panics a thread
something like
thread 'tokio-runtime-worker' panicked at 'called
Option::unwrap()on aNonevalue', src/search.rs:88:59note: run with
RUST_BACKTRACE=1environment variable to display a backtracethread 'tokio-runtime-worker' panicked at 'called
Result::unwrap()on anErrvalue: PoisonError { .. }', src/search.rs:85:34thread 'notify-rs fsevents loop' panicked at 'called
Result::unwrap()on anErrvalue: PoisonError { .. }', src/filesystem/cache.rs:48:48I think this should be set to all mounts or the 0th by defualt, and outlined in the ui somehow
@conaticus
i think this may fix part of #26