Skip to content

Fix race condition in sendExceptionToDriver #3217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
harendra-kumar merged 1 commit into from
May 14, 2026
Merged

Fix race condition in sendExceptionToDriver #3217

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Streamly/Internal/Data/Fold/Channel/Type.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,8 +314,9 @@ sendExceptionToDriver :: Channel m a b -> SomeException -> IO ()
sendExceptionToDriver sv e = do
tid <- myThreadId
writeIORef (closedForInput sv) True
void $ tryPutMVar (inputSpaceDoorBell sv) ()
-- Should ring the doorbell after sending the message
void $ sendToDriver sv (FoldException tid e)
void $ tryPutMVar (inputSpaceDoorBell sv) ()

data FromSVarState m a b =
FromSVarRead (Channel m a b)
Expand Down
Loading