Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to trim dependencies to reduce image size and build time. The efforts are based on the discussion here and subsequent changes in composer/composer#12580. From what I've been able to deduce myself and based on the discussions, all of this can be dropped without any impact (or otherwise very minimal impact).
I've deliberately only opted to target the
latestimage and it may even be worth considering doing this only from 2.10 forwards, to even further reduce the potential scope of impact.Note that dropping
mercurialcould also be considered to heavily reduce image size, being responsible for most of the image size (in comparison to the PHP base image), however given that I see it still being valid for some usecases, keeping it around makes some sense.