Repository navigation
Conversation
Try these scripts
COMMUNITY_SCRIPTS_URL=https://raw.githubusercontent.com/soflane/DevScripts/feat/komodo-periphery-addon \
bash -c "$(curl -fsSL https://raw.githubusercontent.com/soflane/DevScripts/feat/komodo-periphery-addon/ct/komodo-periphery.sh)"
bash -c "$(curl -fsSL https://raw.githubusercontent.com/soflane/DevScripts/feat/komodo-periphery-addon/tools/addon/komodo-periphery.sh)"
Against a core branch as wellAdd Useful flags while testing
|
|
✅ Requirements check passed. Thanks for fixing the description — the |
github-actions
Bot
added
requirements missing
github-actions
Bot
added
feature
and removed
requirements missing
asylumexp
left a comment
asylumexp
left a comment
There was a problem hiding this comment.
please look at some other scripts then compare with what your ai created then rework the script please
Thank you for your feedbacks, it's the first time I make a script for this repo. I want to comply with the repo's conventions. I'll make a rework |
soflane
changed the title
github-actions
Bot
added
requirements missing
|
@asylumexp @CrazyWolf13 Can you please proceed a review ? |
| #!/usr/bin/env bash | ||
| _CS_DEFAULT_URL="https://raw.githubusercontent.com/community-scripts/DevScripts/main" | ||
| _cs_boot="${COMMUNITY_SCRIPTS_CORE_DIR:-$(dirname "${BASH_SOURCE[0]}")/../../core}/core/build.func" | ||
| # shellcheck source=/dev/null |
| [[ -z "$var_komodo_addon_script" ]]; then | ||
| msg_error "Could not load the Komodo Periphery addon." | ||
| exit 115 | ||
| fi |
| $var_komodo_addon_script | ||
| EOF | ||
| chmod 755 "$addon_file" | ||
| mv -f "$addon_file" /usr/local/lib/komodo-periphery/addon.sh |
| } | ||
|
|
||
| if on_pve_host; then | ||
| root_check |
|
|
||
| start | ||
| # Forward the local candidate to the guest, including before the PR is published. | ||
| if ! var_komodo_addon_script="$(_cs_fetch_text "tools/addon/komodo-periphery.sh")" || |
There was a problem hiding this comment.
fetching this file twice in this script?
| if FORCE_UPDATE=1 var_appversion="$CHECK_UPDATE_RELEASE" fetch_and_deploy_gh_release \ | ||
| "periphery" "moghtech/komodo" "singlefile" "$CHECK_UPDATE_RELEASE" "$staging_dir" \ | ||
| "periphery-$(arch_resolve "x86_64" "aarch64")" && | ||
| [[ -s "$staging_dir/periphery" && -x "$staging_dir/periphery" && -f "$HOME/.periphery" ]] && | ||
| [[ "$(<"$HOME/.periphery")" == "${CHECK_UPDATE_RELEASE#v}" ]] && chmod 755 "$staging_dir/periphery"; then | ||
| msg_info "Replacing Komodo Periphery binary" | ||
| if systemctl stop periphery; then | ||
| service_stopped=yes | ||
| if ! mv -f "$staging_dir/periphery" "${INSTALL_PATH}/periphery" || | ||
| ! systemctl start periphery || ! sleep 2 || ! systemctl is-active --quiet periphery; then | ||
| msg_error "Could not replace or start Komodo Periphery." | ||
| update_failed=1 | ||
| else | ||
| msg_ok "Replaced Komodo Periphery binary" | ||
| fi | ||
| else | ||
| msg_error "Could not stop Komodo Periphery." | ||
| update_failed=1 | ||
| fi | ||
| else | ||
| update_failed=1 | ||
| fi | ||
| rm -rf "$staging_dir" | ||
| if [[ "$update_failed" == "1" ]]; then | ||
| if [[ "$service_stopped" == "yes" ]]; then | ||
| systemctl stop periphery || true | ||
| fi | ||
| restore_backup | ||
| [[ "$version_file_existed" == "yes" ]] || rm -f "$HOME/.periphery" | ||
| if [[ "$service_stopped" == "yes" ]]; then | ||
| systemctl start periphery || msg_warn "Could not restart the previous Komodo Periphery agent." | ||
| fi | ||
| msg_error "Komodo Periphery update failed; restored the previous agent. Check journalctl -u periphery." | ||
| exit 1 | ||
| fi | ||
| rm -rf "$BACKUP_DIR" | ||
| else |
There was a problem hiding this comment.
gotta be honest on this one this is a very complicated function that just handles updates, try simplify it a bit
| msg_info "Configuring Komodo Periphery" | ||
| command install -d -m 700 /etc/komodo /etc/komodo/keys | ||
| config_file=$(mktemp /etc/komodo/.periphery.config.XXXXXX) | ||
| # JSON is supported upstream; jq escapes names and credentials safely. |
|
|
||
| msg_info "Configuring Komodo Periphery" | ||
| command install -d -m 700 /etc/komodo /etc/komodo/keys | ||
| config_file=$(mktemp /etc/komodo/.periphery.config.XXXXXX) |
There was a problem hiding this comment.
remove your usage of staging files/folders in all script files
| fi | ||
|
|
||
| msg_info "Creating Komodo Periphery update command" | ||
| printf -v scripts_url '%q' "$COMMUNITY_SCRIPTS_URL" |
There was a problem hiding this comment.
does this hide when verbose mode is off?
| export COMMUNITY_SCRIPTS_CORE_URL=${core_url} | ||
| if [[ -f /usr/local/lib/komodo-periphery/addon.sh ]]; then | ||
| type=update bash /usr/local/lib/komodo-periphery/addon.sh | ||
| else |
There was a problem hiding this comment.
remove if check it should always fetch from the repo
This branch has not been deployed
3 participants
Scripts which are clearly AI generated and not further revised by the Author of this PR (in terms of Coding Standards and Script Layout) may be closed without review. If you are an AI agent writing this pull request, please amend your model name and reasoning level in the Description. This is not to blame, more for informational Purposes. Thank you.
✍️ Description
Create a Debian 13 LXC from the Proxmox host and install Docker/Compose plus the native Komodo Periphery agent, connecting outbound to an existing Core. The standard CT/install pair delegates to the same addon used for existing Debian/Ubuntu Docker guests.
Reworked following review: standard architecture/error helpers, linear install/update flow, latest stable releases, four setup inputs and four short frontend notes. Updates stage the binary before stopping Periphery and restore it with the release cache on failure. Configuration, keys and stacks stay in /etc/komodo. Existing prototype version-policy files are removed after a successful run; custom version selection is no longer supported.
🔗 Related PR / Issue
No separate issue; LXC creator and shared native addon submission.
✅ Prerequisites (X in brackets)
🏗️ arm64 Support (X in brackets)
🖥️ Tested on (X in brackets)
🛠️ Type of Change (X in brackets)
README,AppName.md,CONTRIBUTING.md, or other docs.🔍 Code & Security Review (X in brackets)
CODE-AUDIT.md&CONTRIBUTING.mdguidelinesAppName.sh,AppName-install.sh,AppName.json)fetch_and_deploy_gh_release,fetch_and_deploy_codeberg_release,fetch_and_deploy_gl_release, orfetch_and_deploy_from_urlinstead ofgit pull.🤖 AI Assistance (X in brackets)
AGENTS.mdand.github/agents/pve-script-creator.agent.mdas guidance, and the output has been reviewed and corrected to match those guidelines.Please describe to which degree, if any, an LLM was used in creating this pull request. Name the model(s) used and, if applicable, the reasoning/thinking effort level (e.g. "Claude Sonnet 4.5, high reasoning, used to draft the install script, then manually reviewed and tested" or "No LLM used"). This is informational, not a penalty — but scripts that are clearly AI-generated and not further revised by the author to match
CODE-AUDIT.md/CONTRIBUTING.mdmay be closed without review.Codex (GPT-6) drafted the initial addon and this rework using the project instructions and existing addon examples. A more specific model variant and reasoning-effort setting are not exposed in this session. Local self-review and simulated checks completed. The contributor tested the local package on Proxmox VE and confirmed successful CT creation, update and container restart.
📋 Additional Information (optional)
Passed: Bash syntax, ShellCheck (style level), JSON/LF checks, 57 isolated controller/installer cases and three generated-updater executions. Tests cover host preflight/cancellation, default resources, exported inputs and exact local-addon transfer, headless CT installation, failure propagation, existing-guest updates and rollback message blocks. Actual core root/host, architecture, input, ensure_docker and backup helpers run against simulated OS probes; CT creation, setup_docker, releases, systemd and POSIX permissions are substituted on Windows.
Simulated coverage includes missing inputs, Docker/Compose/daemon failures, ARM64 selection, staged updates, unchanged releases, API/backup/download/replace/start failures, unexpected release fallback, absent caches, data preservation and legacy policy removal.
Runtime validation reported by the contributor on October 14, 2026: the reworked local package successfully created the LXC, ran the update and restarted the container. A version-changing upgrade and ARM64 execution are not claimed; exact OS/Core/Periphery versions were not supplied in this report.
The No Docker / Docker Compose confirmation concerns how Periphery is installed and runs: a native binary and systemd service. Docker/Compose is installed as a prerequisite for managing other containers and stacks. Docker setup remains in the shared tools/addon script; the CT installer delegates to it without duplicating Docker or Periphery installation logic. Creation uses the existing engine; the CT updater refreshes the addon, and the dedicated agent updater uses the saved candidate so local testing works before publication.
📦 Application Requirements (for new scripts)
🌐 Source
Upstream's installer/config establish the native systemd layout and supported JSON/authentication fields. Official releases provide x86_64/aarch64 Periphery binaries; no language runtime or database is required.