Conversation
The call advanced parser->offset from its current position rather than from parser->first_nonspace, so the resulting offset was wrong for an indented or nested closing fence. The value is never read: finalize takes end_column from parser->curline.size or parser->last_line_length, and the caller goes straight to the end of the line, which uses input.len. Remove the call rather than correct the arithmetic. Closes commonmark#590
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per @nwellnhof in #590: the call is dead, so removing it rather than correcting the arithmetic.
The offset it computes is never read —
finalizetakesend_columnfromcurline.sizeorlast_line_length, and the caller goes straight to the end of the line, which usesinput.len.No behaviour change. All tests pass.
Closes #590