Skip to content

Conversation

@GlassOfWhiskey
Copy link
Contributor

@GlassOfWhiskey GlassOfWhiskey commented Nov 17, 2025

This commit adds support for Python 3.14 wheels

@GlassOfWhiskey GlassOfWhiskey changed the title Drop support for Python 3.9 - Part II Enable Python 3.14 wheels Nov 17, 2025
@GlassOfWhiskey GlassOfWhiskey changed the title Enable Python 3.14 wheels Support Python 3.14 wheels Nov 17, 2025
@GlassOfWhiskey GlassOfWhiskey requested a review from mr-c November 17, 2025 12:04
Copy link
Member

@mr-c mr-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, but this is just the version of Python used to run cibuildwheel; not the version to build wheels for.

Python 3.14 wheels are already built and published: https://pypi.org/project/schema-salad/?abis=cp314#files

The configuration for cibuildwheel is controlled in

skip = ["pp*", "cp31?t-*"]

@mr-c mr-c changed the title Support Python 3.14 wheels run cibuildwheel using Python 3.14 Nov 17, 2025
@mr-c mr-c changed the title run cibuildwheel using Python 3.14 gh-actions: run cibuildwheel using Python 3.14 Nov 17, 2025
@mr-c
Copy link
Member

mr-c commented Nov 17, 2025

I manually kicked off the edited workflow at https://github.com/common-workflow-language/schema_salad/actions/runs/19429195340

@mr-c
Copy link
Member

mr-c commented Nov 17, 2025

Interestingly, their docs are inconsistent, they don't use setup-python here: https://cibuildwheel.pypa.io/en/stable/ci-services/#github-actions but they do use setup-python (without a version range) here: https://github.com/pypa/cibuildwheel?tab=readme-ov-file#example-setup ; in fact their action handles setup-python as a step, so we can probably remove it from our configuration: https://github.com/pypa/cibuildwheel/blob/63fd63b352a9a8bdcc24791c9dbee952ee9a8abc/action.yml#L31-L35

This commit adds support for Python 3.14 wheels.
@codecov
Copy link

codecov bot commented Dec 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.23%. Comparing base (62b48be) to head (99df510).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #979   +/-   ##
=======================================
  Coverage   83.23%   83.23%           
=======================================
  Files          22       22           
  Lines        4994     4994           
  Branches     1192     1192           
=======================================
  Hits         4157     4157           
  Misses        556      556           
  Partials      281      281           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mr-c mr-c merged commit a8a1f9d into main Dec 1, 2025
19 checks passed
@mr-c mr-c deleted the drop-python-3.9 branch December 1, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants