Skip to content

Fix normalization of image id for singularity pre-pulled images #2171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix normalization of image id for singularity pre-pulled images #2171

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cwltool/singularity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,13 +136,13 @@ def is_version_3_10_or_newer() -> bool:
def _normalize_image_id(string: str) -> str:
if ":" not in string:
string += "_latest"
return string.replace("/", "_") + ".img"
return string.replace(":", "_") + ".img"


def _normalize_sif_id(string: str) -> str:
if ":" not in string:
string += "_latest"
return string.replace("/", "_") + ".sif"
return string.replace(":", "_") + ".sif"


class SingularityCommandLineJob(ContainerCommandLineJob):
Expand Down
Loading