-
-
Notifications
You must be signed in to change notification settings - Fork 301
fix(bump): remove NotAllowed related to --get-next option, and other related refactoring
#1645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v4-10-1
Are you sure you want to change the base?
Conversation
56b9440 to
5cc10ae
Compare
5cc10ae to
cfd13e6
Compare
woile
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
I just update the |
cfd13e6 to
fcb9662
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v4-10-1 #1645 +/- ##
==========================================
Coverage ? 98.64%
==========================================
Files ? 60
Lines ? 2651
Branches ? 0
==========================================
Hits ? 2615
Misses ? 36
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@Lee-W @noirbizarre please review |

Changes
dry_run = Truewhile we already haveget_next = True. The latter condition raises aGetNextExit()exception in the original code, so no effect if we setdry_runtoTrue. Moreover, the original code isself.dry_run = Truewhich is ineffective since we never use the member variable.get_nexttonext_version_to_stdout. The variable nameget_nextis very unclear and hard to guess what it will do. I think we can consider renaming the option in the next major release.--get-nextwhen changelog is enabled #1640) ReplaceNotAllowedrelated to--get-nextoption with warnings.GetNextExitexception because we already haveDryRunExit.--get-nextis just--dry-runbut doing less things IMO.