Skip to content

refactor(FileProvider): remove set and get method #1610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

refactor(FileProvider): remove set and get method #1610

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 9 additions & 20 deletions commitizen/providers/base_provider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,8 @@

import json
from abc import ABC, abstractmethod
from collections.abc import Mapping
from pathlib import Path
from typing import Any, ClassVar
from typing import ClassVar

import tomlkit

Expand Down Expand Up @@ -56,19 +55,14 @@ class JsonProvider(FileProvider):
indent: ClassVar[int] = 2

def get_version(self) -> str:
document = json.loads(self.file.read_text())
return self.get(document)
version = json.loads(self.file.read_text())["version"]
assert isinstance(version, str)
return version

def set_version(self, version: str) -> None:
document = json.loads(self.file.read_text())
self.set(document, version)
self.file.write_text(json.dumps(document, indent=self.indent) + "\n")

def get(self, document: Mapping[str, str]) -> str:
return document["version"]

def set(self, document: dict[str, Any], version: str) -> None:
document["version"] = version
self.file.write_text(json.dumps(document, indent=self.indent) + "\n")


class TomlProvider(FileProvider):
Expand All @@ -77,16 +71,11 @@ class TomlProvider(FileProvider):
"""

def get_version(self) -> str:
document = tomlkit.parse(self.file.read_text())
return self.get(document)
version = tomlkit.parse(self.file.read_text())["project"]["version"] # type: ignore[index]
assert isinstance(version, str)
return version

def set_version(self, version: str) -> None:
document = tomlkit.parse(self.file.read_text())
self.set(document, version)
self.file.write_text(tomlkit.dumps(document))

def get(self, document: tomlkit.TOMLDocument) -> str:
return document["project"]["version"] # type: ignore[index,return-value]

def set(self, document: tomlkit.TOMLDocument, version: str) -> None:
document["project"]["version"] = version # type: ignore[index]
self.file.write_text(tomlkit.dumps(document))
Loading