Repository navigation
Conversation
Observers of coalition members receive forms owned by the leader, but their forms:version cache key only followed their own NGO's FormsVersion, so editing a shared published form (or sharing one) never told their apps to refetch. The key now also covers the owners' FormsVersion and the shared form ids; forms:fetchAll returns the same key. NGOs outside a coalition keep their current key.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In a coalition, observers of member NGOs receive forms owned by the leader (
CoalitionFormAccess). Theirforms:versioncache key was only their own NGO'sFormsVersion, which changes only when the member's own forms change. Editing a shared published form, or sharing a form with them, left their key unchanged, so the mobile app kept the old forms.forms:fetchAllreturned aversionhashed from form ids only, so it didn't change on content edits either.Change
ObserverFormsVersion.GetAsync: the key is the NGO's ownFormsVersion, plus theFormsVersionof every NGO whose forms are shared with it and the shared form ids (citizen reporting forms excluded, as infetchAll).GET forms:versionandGET forms:fetchAllboth return this key.FormsVersion), so their observers don't refetch.Testing
Feature.Formsbuilds;Feature.Forms.UnitTestspass (185).