Repository navigation
Emails: plain-text alternative and current year in the footer - #1153
Merged
Merged
Conversation
- Every email template has a .txt version, filled with the same values and sent beside the HTML (multipart/alternative over SMTP, Body.Text over SES), so clients that show no HTML (Mail.ru) read it. - The footer's year is ~$year$~, filled with the current year (was a fixed 2024). - EnqueueSendEmail carries the text body; ISendEmailJob keeps its 3-argument SendAsync for jobs already queued.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
… documentation comment' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
… documentation comment' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…ath.Combine' may silently drop its earlier arguments' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
.txtversion next to the.html, filled with the same values. Both are sent: multipart/alternative over SMTP,Body.Textover SES. Some clients (Mail.ru) show nothing for HTML-only mail.~$year$~, filled with the current year (UTC), in all five templates.Compatibility
EmailModelgainsTextBody;IJobService.EnqueueSendEmailtakes it.ISendEmailJobadds a 4-argumentSendAsync(to, subject, body, textBody)and keeps the 3-argument one, so jobs already in the Hangfire queue at deploy still run (HTML only).Tests
Vote.Monitor.Core.UnitTests/EmailTests: every email has the current year and no leftover placeholders in both bodies; the invitation's text; the exact text of a citizen report with input, select and rating answers, notes and attachments.