Skip to content

cluster() is not numeric-only, and the error already said so (#827 follow-up) #832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OffgridwithJD merged 1 commit into from
Aug 29, 2026
Merged

cluster() is not numeric-only, and the error already said so (#827 follow-up) #832

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pgcolumnar--1.0-alpha2--1.0-alpha3.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,3 +293,6 @@ $sort_status$;

COMMENT ON FUNCTION pgcolumnar.sort_status(regclass)
IS 'how much of an ordered columnar table is still in its ordered run, and by what kind of ordering (#301, #761)';

COMMENT ON FUNCTION pgcolumnar.vacuum_sorted(regclass, name[])
IS 'compact a columnar table, storing rows sorted ascending (NULLS LAST) on the given columns. With no columns, applies the table''s declared sort_by key from set_options (#288), like a bare CLUSTER re-applying a remembered index; errors if none is declared. Supports any btree-orderable column including text and numeric, unlike Z-order cluster(), which takes integer, date/time, boolean and floating-point columns only. One-shot: not auto-maintained.';
2 changes: 1 addition & 1 deletion pgcolumnar--1.0-alpha3.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -895,7 +895,7 @@ CREATE FUNCTION pgcolumnar.vacuum_sorted(
AS 'MODULE_PATHNAME', 'pgcolumnar_vacuum_sorted';

COMMENT ON FUNCTION pgcolumnar.vacuum_sorted(regclass, name[])
IS 'compact a columnar table, storing rows sorted ascending (NULLS LAST) on the given columns. With no columns, applies the table''s declared sort_by key from set_options (#288), like a bare CLUSTER re-applying a remembered index; errors if none is declared. Supports any btree-orderable column including text (unlike the numeric-only Z-order cluster()). One-shot: not auto-maintained.';
IS 'compact a columnar table, storing rows sorted ascending (NULLS LAST) on the given columns. With no columns, applies the table''s declared sort_by key from set_options (#288), like a bare CLUSTER re-applying a remembered index; errors if none is declared. Supports any btree-orderable column including text and numeric, unlike Z-order cluster(), which takes integer, date/time, boolean and floating-point columns only. One-shot: not auto-maintained.';

/*
* One-argument form: apply the declared sort_by key (#288). A VARIADIC function
Expand Down
3 changes: 2 additions & 1 deletion src/columnar_vacuum.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1740,7 +1740,8 @@ vacuum_sorted_gate_is_noop(Relation rel, int ncols, AttrNumber *atts)
* declared sort_by key from pgcolumnar.options (#288), like a bare
* "CLUSTER t" re-applying a remembered index; it errors if none is set.
* Sorting supports any btree-orderable column, text included; the Z-order
* cluster() path is numeric-only.
* cluster() path takes integer, date/time, boolean and floating-point
* columns.
*/
Datum
pgcolumnar_vacuum_sorted(PG_FUNCTION_ARGS)
Expand Down
Loading