Fix nil-pointer exception in SSH authentication#181
Open
SimonBaeumer wants to merge 3 commits intomasterfrom
Open
Fix nil-pointer exception in SSH authentication#181SimonBaeumer wants to merge 3 commits intomasterfrom
SimonBaeumer wants to merge 3 commits intomasterfrom
Conversation
3 tasks
dylanhitt
previously approved these changes
Nov 22, 2021
Member
|
This looks good. I assume once #180 gets through a rebase should fix the failing pipeline. Just a reminder I believe you will need to update the test case to adhere to the new function signature. |
dylanhitt
dismissed
their stale review
I didn't mean to approve just to comment.
|
Any news on this? :) |
dylanhitt
force-pushed
the
fix-nil-pointer-execption-ssh
branch
from
cb90450 to
e86cef6
Compare
dylanhitt
force-pushed
the
fix-nil-pointer-execption-ssh
branch
2 times, most recently
from
c29fb73 to
44421b7
Compare
Member
|
Hey @stdevel sorry for the wait I've been settling into a new position the past couple of months. I'll probably try to pull this across early next week. So expect a 2.5.1 release. Best |
dylanhitt
force-pushed
the
fix-nil-pointer-execption-ssh
branch
from
44421b7 to
8fb23fc
Compare
dylanhitt
force-pushed
the
fix-nil-pointer-execption-ssh
branch
from
8fb23fc to
e7f0bb8
Compare
|
Hi @dylanhitt, Best wishes, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ToDo
Checklist
Linux,WindowsandmacOS?