-
Notifications
You must be signed in to change notification settings - Fork 11k
Add support for sage attention 3 in comfyui, enable via new cli arg #11026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
--use-sage-attiention3
Attention 3 takes effect is reduced to 1024 (although the improvement is not significant at this scale).
|
@mengqin for this PR, could you remove the startup argument for sage3? sage3 is very lossy, so after this PR gets merged with that gone, we can create a node that will only apply sage3 to certain blocks + sampling steps to make the results much better. we would want to avoid users turning on sage3 for everything, as that will basically make everything return very poor results. |
Thanks for the review. I removed the command-line argument switch and only kept the relevant attention functions and their registrations. |
This is basic Sage Attention 3 support. Because it is still unstable and differs significantly from previous versions of Sage Attention, a separate switch --use-sage-attiention3 is provided to enable or disable it. You need to install Sage Attention 3 in your environment before enabling it.