Open
Conversation
amoeba
force-pushed
the
fix/windows-installer-cant-uninstall
branch
from
a7c0edc to
1db6f5a
Compare
Member
Author
|
I just downloaded the MSI from the CI artifacts and it installs and uninstalls (through add/remove programs) cleanly. |
zeroshade
reviewed
Feb 18, 2026
| </Fragment> | ||
| <Product Id="5B742771-61E1-4DC1-9276-6E1287282B3F" Name="dbc" | ||
| Manufacturer="Columnar Technologies Inc." Version="{{ .Version }}" | ||
| <Product Id="*" Name="dbc" Language="1033" |
Member
There was a problem hiding this comment.
I think this needs to be one line up
Member
Author
There was a problem hiding this comment.
This isn't quite right. Will fix in a sec.
Member
Author
There was a problem hiding this comment.
Never mind, I can't read. Should be good now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates our WiX template to fix an issue where dbc can't be uninstalled with Add/Remove programs. We were setting two values in our .wxs template incorrectly. The "Product Code" should vary between releases and the "Package Code" should as well.
See:
Closes #319