Skip to content

Repo hardening: fix install instructions, dead imports, hygiene#1

Open
cognis-digital wants to merge 3 commits into
mainfrom
cognis-audit/repo-hardening
Open

Repo hardening: fix install instructions, dead imports, hygiene#1
cognis-digital wants to merge 3 commits into
mainfrom
cognis-audit/repo-hardening

Conversation

@cognis-digital

@cognis-digital cognis-digital commented Jun 12, 2026

Copy link
Copy Markdown
Owner

This PR applies a few small, mechanically-verified hardening fixes found by an automated audit of the Cognis suite:

  • fix 2 broken pip install line(s) in README (package is not on PyPI; use the working git+https install)
  • remove 3 unused import(s) (ruff F401/F811)

Each change is deterministic; all touched Python files were confirmed to still compile (py_compile) before this PR was opened.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your first PR! 🚀 A maintainer will review under the collaboration-pull model (see CONTRIBUTING.md).

@cognis-digital cognis-digital force-pushed the cognis-audit/repo-hardening branch from 3a02723 to 92356ab Compare June 12, 2026 21:52
…rehensive cross-platform install scripts

- README opens with a plain-language "What is this?" overview
- comprehensive Install section + install.sh / install.ps1 (pipx / uv / pip git+https / source)
- verified build-out: real test + CLI audit embedded (README Verification + AUDIT.md)
@cognis-digital cognis-digital force-pushed the cognis-audit/repo-hardening branch from 32c21a1 to 1e9f081 Compare June 13, 2026 12:41
Cognis Digital added 2 commits June 13, 2026 09:18
- core.py load_export: guard empty path (ValueError), re-raise
  PermissionError with context instead of raw OSError traceback
- core.py analyze: guard non-dict owner value instead of crashing
  with AttributeError on .get()
- cli.py _write_output: catch OSError and print clean error to
  stderr; propagate for caller to return exit code 2
- cli.py main: catch PermissionError from load_export (not a
  subclass of ValueError/FileNotFoundError); wrap write calls so
  any OSError returns 2 without a traceback
- mcp_server.py: fix broken module-level import of non-existent
  scan/to_json; defer import and wire to actual analyze/load_export
  API with exception handling in the tool handler
- tests: 6 new tests covering owner non-dict, empty repos, non-string
  file content, empty path, write-error exit code, mcp_server import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant