Repository navigation
Plucks waiting on a device follow one set of rules - #117
Merged
Merged
Conversation
…nsion, the iPhone app and its shares all drain through createQueue's Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Per4f8yL5A7nL9frZVDJj7 Signed-off-by: NiallJoeMaher <nialljoemaher@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The keep and drop rules for plucks waiting on a device now live in one place,
createDraininpackages/client/src/queue.ts. A pluck that is sent or refused leaves the queue. Anything else (offline, signed out, a 429 or 5xx) keeps it and stops the drain. Only one drain runs at a time.TopBar.tsxdrops its own loop and usescreateQueueoverlocalStorage, with the Web Lock kept. The status mapping is the client's newanswer(res), whichcreateClientnow uses too. Entries already queued in the old{ draft, body }shape are read using the draft's key as their id.onPluckednow takes the draft key, which is allItemListused.createDrainwith a store that can only read and remove: the share extension writes the files and the app only takes them away, so rewriting the whole list would race with it. The Swift file format is unchanged. Shares are still kept when signed out, on a 5xx or offline, and dropped only on a refusal or when unreadable. The body still carriesclientKey: <file name>.createQueueas before.client.test.tsnow covers keep-on-signed-out, keep-on-offline/down and keep-on-unexpected, with the same clientKey on every resend. The existing tests cover drop-on-refused, order, no double send and plucks queued mid-drain.architecture.mddrops candidate 4 and updates thepackages/clientrow.Not run:
pnpm e2eandpnpm design(the lead runs them). The iPhone paths have not been run on a device.🤖 Generated with Claude Code
https://claude.ai/code/session_01Per4f8yL5A7nL9frZVDJj7