Repository navigation
Connector: save_item reads tags as the library does, and the connector cannot make a List public - #116
Merged
Conversation
…arest Tags), and the connector has no way to make a List public Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Per4f8yL5A7nL9frZVDJj7 Signed-off-by: NiallJoeMaher <nialljoemaher@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
save_itemno longer checks tag ids by hand. It resolvestagIdsthrough the library'stagIdsFor(via a newPluckLibrary.tagIdsFor), the same code REST andbatch_updateuse: ids or names of existing Tags, and an unknown one is refused with the nearest Tags. Still checked before anything is saved.PluckLibrary.setVisibilityis nowmakePrivate, so the adapter itself has no way to publish a List.update_liststill refusesvisibility: "public"with its explanation.connector.test.ts: save_item andtagIdsForgive the same refusal for the same ref, and a tag name works; the adapter has no visibility/public/share call andmakePrivate(id, "public")still leaves the List private.docs/mcp.mdupdated for thesave_itemtag input.Gates:
pnpm typecheck,pnpm lint,pnpm test(70 files, 447 tests) pass.🤖 Generated with Claude Code
https://claude.ai/code/session_01Per4f8yL5A7nL9frZVDJj7