Bugfix/frontend - #458
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the MessageArchive frontend to work with the current React DOM API (switching from legacy render() to createRoot()), adds an explicit TypeScript typecheck step to the frontend build, and bumps the overall project version/changelog accordingly.
Changes:
- Replace
react-dom’s legacyrender()usage withcreateRoot()in the frontend entrypoint. - Add a
typecheckscript and run TypeScript checking as part of the frontend build. - Bump Emulsion version to
5.0.1and record the fix inCHANGELOG.md(plus SPDX year range updates).
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Emulsion/Emulsion.fsproj | Bumps application version to 5.0.1. |
| Emulsion.MessageArchive.Frontend/package.json.license | Updates SPDX copyright year range. |
| Emulsion.MessageArchive.Frontend/package.json | Adds typecheck and runs tsc before Parcel; pins React/ReactDOM version. |
| Emulsion.MessageArchive.Frontend/package-lock.json.license | Updates SPDX copyright year range. |
| Emulsion.MessageArchive.Frontend/package-lock.json | Updates lockfile entries for pinned React/ReactDOM versions. |
| Emulsion.MessageArchive.Frontend/app.tsx | Migrates frontend mounting from render() to createRoot() with a null-container guard. |
| CHANGELOG.md | Adds 5.0.1 release notes and updates comparison links. |
Files not reviewed (1)
- Emulsion.MessageArchive.Frontend/package-lock.json: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.