Repository navigation
Ship only bundleReplacements targets in distributions - #7024
Merged
Merged
Conversation
jaymcnallie
requested review from
derekwilhelm,
jrnorth,
lavoywj,
vinamartin and
zkirksey
October 11, 2026 23:55
zkirksey
approved these changes
Oct 12, 2026
lavoywj
approved these changes
Oct 12, 2026
jrnorth
approved these changes
Oct 12, 2026
derekwilhelm
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
etc/org.apache.karaf.features.xmlusesbundleReplacementsto converge third-party pins on DDF's versions, but Karaf applies them only at install time.features-add-to-repositorystill staged the pinned originals, and some replacement targets were never staged.Jackson
jackson-dataformat-yaml,jackson-jaxrs-baseandjackson-jaxrs-json-providerat${jackson.version}were never insystem/, so Karaf downloaded them from Maven Central or~/.m2. With no network,profile:install standardfailed withCould not find artifact ... jackson-jaxrs-base:jar:2.22.3. The kernel zip had no 2.22.3 Jackson at all.BouncyCastle and commons-text
bcprov/bcpkix/bcutil1.83 (pax-webkeycloak-adapter-core) andcommons-text1.8 (Shiroshiro-core) shipped but are never installed. New replacements: BouncyCastle[1.80,2)->${bouncy.version}, commons-text[1,2)->${commons-text.version}.Changes
etc/org.apache.karaf.features.xml: BouncyCastle and commons-text replacementsfeatures/kernel: staging-onlybundle-replacementsfeature with every replacement targetdistribution/pom.xml:prune-replaced-bundlesantrun execution deletes replaced versions before assembly and fails the build if a target is missing; used bykernel(inherited byddf) andddf-catalogVerified
profile:install standardcompletes with no resolution errors;jackson/2.18.10,jackson-jaxrs/2.22.2,keycloak-adapter-coreandshiro-core/2.2.1also install and resolve to the replacement versions